From 767d46e05bbc88eb3c236cf468f9432c7fe0ce05 Mon Sep 17 00:00:00 2001
From: Emil Fresk <emil.fresk@gmail.com>
Date: Thu, 25 Feb 2021 17:32:12 +0100
Subject: [PATCH] Review fixes

---
 Cargo.toml                   | 1 -
 macros/src/codegen.rs        | 3 ++-
 macros/src/codegen/module.rs | 8 ++------
 src/lib.rs                   | 2 +-
 4 files changed, 5 insertions(+), 9 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 5589aa6e89..0a9645193f 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -53,7 +53,6 @@ required-features = ["__v7"]
 [dependencies]
 cortex-m = "0.7.0"
 cortex-m-rtic-macros = { path = "macros", version = "0.6.0-alpha.0" }
-# rtic-core = { git = "https://github.com/rtic-rs/rtic-core", branch = "new_monotonic" }
 rtic-monotonic = { git = "https://github.com/rtic-rs/rtic-monotonic", branch = "master" }
 rtic-core = "0.3.1"
 heapless = "0.5.0"
diff --git a/macros/src/codegen.rs b/macros/src/codegen.rs
index 32e7da0543..7885a4a994 100644
--- a/macros/src/codegen.rs
+++ b/macros/src/codegen.rs
@@ -127,6 +127,7 @@ pub fn app(app: &App, analysis: &Analysis, extra: &Extra) -> TokenStream2 {
                 #[doc(hidden)]
                 pub type #mangled_name = #ty;
 
+                /// This module holds the static implementation for `#name::now()`
                 #[allow(non_snake_case)]
                 pub mod #name {
                     /// Access the global `Monotonic` implementation, not that this will panic
@@ -154,7 +155,7 @@ pub fn app(app: &App, analysis: &Analysis, extra: &Extra) -> TokenStream2 {
     let rt_err = util::rt_err_ident();
 
     quote!(
-        /// Implementation details
+        /// The RTIC application module
         pub mod #name {
             /// Always include the device crate which contains the vector table
             use #device as #rt_err;
diff --git a/macros/src/codegen/module.rs b/macros/src/codegen/module.rs
index e480b86559..25260bea32 100644
--- a/macros/src/codegen/module.rs
+++ b/macros/src/codegen/module.rs
@@ -53,13 +53,9 @@ pub fn codegen(
 
         Context::Idle => {}
 
-        Context::HardwareTask(..) => {
-            // None for now.
-        }
+        Context::HardwareTask(_) => {}
 
-        Context::SoftwareTask(..) => {
-            // None for now.
-        }
+        Context::SoftwareTask(_) => {}
     }
 
     if ctxt.has_locals(app) {
diff --git a/src/lib.rs b/src/lib.rs
index 16f2e9fac1..822073999f 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -32,7 +32,7 @@
 #![deny(missing_docs)]
 #![deny(rust_2018_compatibility)]
 #![deny(rust_2018_idioms)]
-// #![deny(warnings)]
+#![deny(warnings)]
 #![no_std]
 
 use cortex_m::{interrupt::InterruptNumber, peripheral::NVIC};